Bring back more php7.2 compatibility for some Nextcloud 20 instances #4150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/php7.2-nextcloud20-errors
branch
from
1e8f8ef to
c028270
Compare
StCyr
approved these changes
Nov 30, 2020
Member
Author
|
/backport to stable.17 |
Member
Author
|
/backport to stable1.7 |
Member
Author
|
/backport to stable1.6 |
|
The backport to stable.17 failed. Please do this backport manually. |
1 similar comment
|
The backport to stable.17 failed. Please do this backport manually. |
|
The backport to stable1.6 failed. Please do this backport manually. |
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dropped php7.2 for the 1.6 release because it's reached EOL as per https://www.php.net/supported-versions.php.
However, it turned out that Nextcloud server doesn't currently check for platform dependency compatibility and so Nextcloud 20 installations that run on php7.2 will update to 1.6 even though their php isn't up to date. This leads to errors like #4063. Since we updated some dependency libs for 7.3+ already, the downgrade to 7.2 isn't easily possible and would certainly be a step back.
So I'm proposing that we fix the php7.2 issues specifically. For this purpose I'm reactivating the lint job. I'll update the PR with any fixes that are necessary to make this pass.
nextcloud/server#24416 is fixing server to do the dependency check and only install apps that are compatible with the current php version. But right now the deployed Nextclouds still pull Mail 1.6+ on ph7.2, so we have to be very careful with composer dependency updates.
Fixes #4063