Make it clear that not all attachments will be sent #7082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
GretaD,
JuliaKirschenheuter and
violoncelloCH
Member
Author
|
@GretaD @JuliaKirschenheuter 🏓 for review |
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/attachment-upload-error-visual
branch
from
aef7d34 to
aea1b65
Compare
| color:red; | ||
| } | ||
| } | ||
Contributor
There was a problem hiding this comment.
please place cursor:pointer; to all child elements
&--counter * { cursor:pointer; }
Member
Author
There was a problem hiding this comment.
ChristophWurst
deleted the
enhancement/attachment-upload-error-visual
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you upload a handful of attachments, the list collapses due to #6660 and upload errors are not noticeable visibly anymore. This changes the color of the collapse handle to reflect errors.
I believe the flow and error handling has still a lot of potential for improvement. E.g. to disable the send button until all errors are handled (user needs to remove the faulty attachment or we never add it) but that requires larger restructuring.