Improve the way attachment look #6660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I found bug, when forwarding - attachments not load. I forgot about this moment. I'll fix it soon. |
sazanof
force-pushed
the
enh/attachments-style-mod
branch
from
12aa643 to
97b869d
Compare
2 tasks
st3iny
requested changes
Jun 17, 2022
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Tested and works so far. Overall, it already looks like the mockups. Good job!
General feedback
- Please rename
src/components/Attachment.vuetosrc/components/ComposerAttachment.vueto clearly differentiate the component from thread envelope attachments.
sazanof
force-pushed
the
enh/attachments-style-mod
branch
2 times, most recently
from
77feea5 to
996e4fe
Compare
st3iny
reviewed
Jun 17, 2022
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Very nice! One minor thing is left: Please remove font-weight: bold from the file name and we are ready to go.
Signed-off-by: Mikhail Sazanov <[email protected]>
sazanof
force-pushed
the
enh/attachments-style-mod
branch
from
c23bc83 to
258ea67
Compare
Collaborator
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I will be glad if my PR will be useful in some way. Resolves #5768
Of the possible nuances of implementation:
Vue.set(this, 'uploads', {})incomplete(), then due to the fact that it is impossible to correctly identify the necessary object from two identical ones, the progress bar is buggyThere is a parallel PR #6310 which is related to this. It may be worth using the same component to display the attachment.
If you have the opportunity, please take a look and give your comments. Thanks!
BTW the previous version was a bit in a different style =) :
And yes, maybe I overdid it a bit in the code (he shrugs his shoulders)
Signed-off-by: Mikhail Sazanov [email protected]