Replace NcMultiselect with NcSelect #8814
Conversation
GretaD
force-pushed
the
replace/multiselect-select
branch
2 times, most recently
from
db1c311 to
9bf0dad
Compare
GretaD
force-pushed
the
replace/multiselect-select
branch
from
947d900 to
4c5ca8e
Compare
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
replace/multiselect-select
branch
from
4c5ca8e to
8723b6c
Compare
Signed-off-by: greta <[email protected]>
|
i tried to test every component. Please test it before approving because its a bit change and i might have missed something. |
| class="multiselect-search-tags" | ||
| :options="tags" | ||
| label="displayName" | ||
| label="name" |
There was a problem hiding this comment.
thats a copy paste issue. it should be as it was
| input-id="select-email-input" | ||
| :searchable="false" | ||
| :placeholder="t('mail', 'Select account')" | ||
| :clear-on-select="false" |
There was a problem hiding this comment.
``
| :clear-on-select="false" | |
| :clear-search-on-select="false" |
| input-id="select-email-input" | ||
| :multiple="true" | ||
| :placeholder="t('mail', 'Contact or email address …')" | ||
| :clear-on-select="true" |
There was a problem hiding this comment.
| :clear-on-select="true" | |
| :clear-search-on-select="true" |
There was a problem hiding this comment.
Also underneath the events are wrong
@search-change should be @search
and @tag should be @option:created
https://vue-select.org/api/events.html
| </NcSelect> | ||
| <button | ||
| :title="t('mail','Toggle recipients list mode')" | ||
| :name="t('mail','Toggle recipients list mode')" |
There was a problem hiding this comment.
should stay title not a vue component
| input-id="select-email-input" | ||
| :multiple="true" | ||
| :placeholder="t('mail', 'Contact or email address …')" | ||
| :clear-on-select="true" |
| :taggable="true" | ||
| label="label" | ||
| track-by="email" | ||
| input-id="select-email-input" |
There was a problem hiding this comment.
working on it, thanks a lot Hamza.
| </label> | ||
| <div class="composer-fields--custom"> | ||
| <Select | ||
| <NcSelect |
There was a problem hiding this comment.
When clicking on the empty line underneath, an empty select rectangle opens up, don't think this is supposed to happen
GVodyanov
left a comment
GVodyanov
left a comment
There was a problem hiding this comment.
Graphical issue in composer
thank you grigory for the review, this pr is outdated because we are gettting in the #9144 |
After the release of nc/vue 8.0.0 NcMultiselect is deprecated and replaced by NcSelect: https://github.com/nextcloud-libraries/nextcloud-vue/releases/tag/v8.0.0