Update to nextcloud/vue 8

[hamza221]

Composer state : I couldn't replicate the unwrapped state we had with the counter

1	2	3

[ChristophWurst]

For a reviewable upgrade, I would suggest to clean up our code from removed components while staying on the old nc/vue, then bump the lib and do the rest of the changes.

Something like

1. A PR against main to replace NcMultiselect with NcSelect
2. A PR against main to migrate NcPopoverMenu
3. ...
4. Bump nc/vue in package.json

https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/CHANGELOG.md#boom-breaking-changes

[GretaD]

For a reviewable upgrade, I would suggest to clean up our code from removed components while staying on the old nc/vue, then bump the lib and do the rest of the changes.

Something like

1. A PR against main to replace NcMultiselect with NcSelect

i have started that one: its almost done, need to rebase it and thats it think: #8814

[GretaD]

Lets merge this one and close mine #8814
This way we avoid more work from hamza to resolve conflicts

[hamza221]

• The only know issue is composer ncSelects, working on fixing it

[GretaD]

2 small bugs:

[ChristophWurst]

Looks sane but didn't test yet

Any strong reason for aliasing NcSelect to SelectVue?

[ChristophWurst]

nit: BEM and getting rid of the mail-empty-content container

[hamza221]

Any strong reason for aliasing NcSelect to SelectVue?

Select tag already exists in Html, and Not NcSelect just because we're already aliasing other components, so to keep it consistent

[ChristophWurst]

For consistency with other apps and the upstream name I would prefer NcSelect

[ChristophWurst]

The only know issue is composer ncSelects, working on fixing it

still to do?

[hamza221]

still to do?

Done, but I couldn't mimic the old behaviour tho, might still need improvements.
edit: new behaviour in screenshots in the description.

[ChristophWurst]

• BUG: Half a NcSelect

[ChristophWurst]

• BUG: Envelopes with primary color looks a bit odd. Contrast is definitely problematic.

[nimishavijay]

Looks good in the screenshots, just not sure about this weird space on the left, the avatar should have equal spacing on the left, top and bottom

[GretaD]

Bug

• I Cannot close the Account Settings with the close button or clicking outside. I can close it only with esc
• Create calendar and create task - the calendar names are not shown:

[hamza221]

cc @nimishavijay

[GretaD]

tested and rebased, changed 2 small things

[ChristophWurst]

#9144 (comment) is still there and a blocker

edit: seems fixed. I was not on the latest commit.

[ChristophWurst]

• BUG primary color for active mailboxes

Before	After

[nimishavijay]

Much better!

• There is still unequal spacing on the left, top and bottom of the avatar, they should all be equal
• close button should also have a couple of pixels more space on the right

[GretaD]

• BUG primary color for active mailboxes

Before After

this comes from an index.css that overlaps the active state of app-navigation as well as the envelope list. :deep and !important on the component doesnt make any difference.

[ChristophWurst]

If the color is coming from nc/vue for any active element then I assume this must have a purpose. Let's keep it but make the text readable.

[GretaD]

the issue with text on mail was because we force the color on our app. I removed that. The new design is white on active state. See talk as well.

[ChristophWurst]

• BUG

[Vue warn]: Invalid prop: custom validator check failed for prop "additionalTrapElements".

found in

---> <NcDialog>
       <NcAppSettingsDialog>
         <AccountSettings> at src/components/AccountSettings.vue
           <RouterLink>
             <NcAppNavigationItem>
               <NavigationAccount> at src/components/NavigationAccount.vue
                 <NcAppNavigation>
                   <Navigation> at src/components/Navigation.vue
                     <NcContent>
                       <Home> at src/views/Home.vue
                         <App> at src/App.vue
                           <Root> vue.runtime.esm.js:4609

[GretaD]

closed accidentally, because it was mentioned as a fix on the nc/vue pr. sorry about that :)

[GretaD]

i tested all what i could. The PR is huge, im sure we will miss something anyway. The most commonly used actions work fine.
If someone has the patience, please test, otherwise, lets merge it :)