-
Notifications
You must be signed in to change notification settings - Fork 187
Update all feeds from command #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think the feature is fine, but I would like to see this as a separate command. |
|
A command configured like this? $this->setName('news:updater:update-feeds')
->addArgument(
'user-id',
InputArgument::OPTIONAL,
'user id of a user, string'
)
->setDescription('Console API for updating multiple feeds'); |
|
I would call it |
|
@maxolasersquad can you implement the change request so that we can maybe still merge it into the 16.0.0 release? |
|
Yes, I'll work on it right now. |
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
============================================
+ Coverage 91.93% 92.02% +0.09%
- Complexity 759 766 +7
============================================
Files 64 65 +1
Lines 2776 2796 +20
============================================
+ Hits 2552 2573 +21
+ Misses 224 223 -1
Continue to review full report at Codecov.
|
|
FYI, I'll be leaving town tomorrow morning and will not have much Internet access until I return Monday evening. I'm not sure what the timeline for the 16.0 release is. Hopefully I can get all suggestion resolved on time. |
|
I plan the release latest when NC 22 final is released. And we could also move this to 16.1.0 |
Closes #1359 Signed-off-by: David Baucum <[email protected]>
Changed - Added vue and ng-vue packages (#1421) - Reimplemented relative time formatting as a filter (#1450) - Added new `news:updater:update-user` command to update the feeds of a single user (#1360). Signed-off-by: Benjamin Brahmer <[email protected]>
Changed - Added new `news:updater:update-user` command to update the feeds of a single user (#1360). Fixed - Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (#1488) Signed-off-by: Benjamin Brahmer <[email protected]>
Changed - Added new `news:updater:update-user` command to update the feeds of a single user (#1360). Fixed - Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (#1488) Signed-off-by: Benjamin Brahmer <[email protected]>
Changed - Added new `news:updater:update-user` command to update the feeds of a single user (nextcloud#1360). Fixed - Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (nextcloud#1488) Signed-off-by: Benjamin Brahmer <[email protected]>
Closes #1359
This is not at all tested. I'd like feedback about if this feature is desired and if my approach here is the correct one.