Fix favicon element making broken requests #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mormegil-cz
force-pushed
the
bugfix/favicon-broken-requests
branch
from
5f2ff57 to
17994ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
============================================
+ Coverage 92.00% 92.02% +0.01%
Complexity 766 766
============================================
Files 65 65
Lines 2803 2796 -7
============================================
- Hits 2579 2573 -6
+ Misses 224 223 -1
Continue to review full report at Codecov.
|
The markup for favicon `<img>` element in feed item used `src` instead of `ng-src`, causing browser to make broken requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` Changing the attribute to `ng-src` fixed that. Signed-off-by: mormegil <[email protected]>
mormegil-cz
force-pushed
the
bugfix/favicon-broken-requests
branch
from
17994ac to
7df6308
Compare
SMillerDev
approved these changes
Aug 23, 2021
Grotax
added a commit
that referenced
this pull request
Sep 2, 2021
Changed - Added new `news:updater:update-user` command to update the feeds of a single user (#1360). Fixed - Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (#1488) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Sep 2, 2021
Changed - Added new `news:updater:update-user` command to update the feeds of a single user (#1360). Fixed - Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (#1488) Signed-off-by: Benjamin Brahmer <[email protected]>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Added new `news:updater:update-user` command to update the feeds of a single user (nextcloud#1360). Fixed - Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (nextcloud#1488) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markup for favicon
<img>element in feed item usedsrcinstead ofng-src, causing browser to make broken requests for.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7DChanging the attribute to
ng-srcfixed that.