Use a fake user to skip database queries #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting a user runs 2 queries: 1. Load the user from oc_users 2. Load the preferences This is somewhat dangerous, but all methods only rely on the userId and the objects are not cached anywhere on the way, so this should still work and does in tests Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/user-fake-user-object
branch
from
77ec02e to
d59ae09
Compare
nickvergessen
requested review from
ChristophWurst,
danxuliu and
vitormattos
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting a user runs 2 queries:
This is somewhat dangerous, but all methods only rely on the
userId and the objects are not cached anywhere on the way,
so this should still work and does in tests
Query log from starting a call with 70 users in a room