Group DB queries on pushing multiple notifications until we flush()

[nickvergessen]

• Based on Use a fake user to skip database queries #1157

[nickvergessen]

Rebased after merge of #1157

[nickvergessen]

Please review @vitormattos @danxuliu so this goes in for 24

[danxuliu]

Other than the comments, code looks good (but I have not tested it).

[danxuliu]

Tested and, from my limited knowledge, works 👍

Note that I have not tested the scenario of having some device or status already loaded and then having to load some more when flushing the payloads (as I did not know how to trigger that :-) ); I just tested starting a call in Talk, which caused all the devices and statuses to be loaded in flushPayloads.

[nickvergessen]

Note that I have not tested the scenario of having some device or status already loaded and then having to load some more when flushing the payloads (as I did not know how to trigger that :-) )

It is currently not possible without hardcoding something. There is no API call which sends a notification to 1 user and afterwards to a second set of users

[vitormattos]

Do we have integration tests covering this?

[nickvergessen]

Not really. The problem is there is no default API using this. We would need to add one.
But basically the Talk team tests it with every call on mobile apps as the call screen notification is it.