Skip to content

Fix lodash replacing the global underscore #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Mar 25, 2019
Merged

Fix lodash replacing the global underscore #311

nickvergessen merged 1 commit into from
Mar 25, 2019

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 25, 2019

No description provided.

@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Mar 25, 2019
@ChristophWurst ChristophWurst self-assigned this Mar 25, 2019
nickvergessen
nickvergessen approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issues

@nickvergessen nickvergessen merged commit 4b9f904 into master Mar 25, 2019
@nickvergessen nickvergessen deleted the fix/lodash-underscore-conflict branch March 25, 2019 09:32
@ChristophWurst ChristophWurst mentioned this pull request Mar 25, 2019
Merged
@rullzer rullzer mentioned this pull request Mar 26, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review bug regression

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst @nickvergessen