Skip to content

Make the richObjectStringParser a real ES module #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Mar 25, 2019
Merged

Make the richObjectStringParser a real ES module #312

nickvergessen merged 1 commit into from
Mar 25, 2019

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 25, 2019

Fixes define is not a function

This is very likely a regression of #311 as the file still used the old AMD module syntax.

@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Mar 25, 2019
@nickvergessen
Copy link
Member

nickvergessen commented Mar 25, 2019

https://github.com/nextcloud/notifications/pull/312/files?w=1 looks good I guess

@nickvergessen nickvergessen merged commit 029dec7 into master Mar 25, 2019
@nickvergessen nickvergessen deleted the fix/rich-object-string-parser-module branch March 25, 2019 14:59
@rullzer rullzer mentioned this pull request Mar 26, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

No one assigned

Labels

3. to review bug regression

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst @nickvergessen