Skip to content

Send a push message when a notification was deleted #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Jul 18, 2019
Merged

Send a push message when a notification was deleted #318

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7efe105
Send a push message when a notification was deleted
nickvergessen Apr 10, 2019
8c59bb7
Add a capability for the new WEB action type
nickvergessen Apr 10, 2019
6663737
Fix integration test dummy implementation
nickvergessen Apr 30, 2019
976dde7
Adjust the registration to the fallback method
nickvergessen Jul 16, 2019
2c8df86
Implement action-web also in the web frontend
nickvergessen Jul 17, 2019
947847c
Fix unit test
nickvergessen Jul 18, 2019
7a18325
Fall back to default_language
nickvergessen Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix integration test dummy implementation 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 18, 2019
commit 66637374c1fe099c17e1fe160cb9465a113d0c19
22 changes: 21 additions & 1 deletion tests/Integration/app/lib/Notifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,33 @@

class Notifier implements INotifier {

/**
* Identifier of the notifier, only use [a-z0-9_]
*
* @return string
* @since 17.0.0
*/
public function getID(): string {
return 'notificationsintegrationtesting';
}

/**
* Human readable name describing the notifier
*
* @return string
* @since 17.0.0
*/
public function getName(): string {
return 'Integration test';
}

/**
* @param INotification $notification
* @param string $languageCode The code of the language that should be used to prepare the notification
* @return INotification
* @throws \InvalidArgumentException When the notification was not prepared by a notifier
*/
public function prepare(INotification $notification, $languageCode) {
public function prepare(INotification $notification, string $languageCode): INotification {
if ($notification->getApp() === 'notificationsintegrationtesting') {
$notification->setParsedSubject($notification->getSubject());
$notification->setParsedMessage($notification->getMessage());
Expand Down