Skip to content

Send a push message when a notification was deleted #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Jul 18, 2019
Merged

Send a push message when a notification was deleted #318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7efe105
Send a push message when a notification was deleted
nickvergessen Apr 10, 2019
8c59bb7
Add a capability for the new WEB action type
nickvergessen Apr 10, 2019
6663737
Fix integration test dummy implementation
nickvergessen Apr 30, 2019
976dde7
Adjust the registration to the fallback method
nickvergessen Jul 16, 2019
2c8df86
Implement action-web also in the web frontend
nickvergessen Jul 17, 2019
947847c
Fix unit test
nickvergessen Jul 18, 2019
7a18325
Fall back to default_language
nickvergessen Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust the registration to the fallback method 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 18, 2019
commit 976dde7ada7baf12c9eb4e78791a306d95ffebca
2 changes: 1 addition & 1 deletion lib/AppInfo/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ protected function registerAdminNotifications(): void {
$this->getContainer()
->getServer()
->getNotificationManager()
->registerNotifier(AdminNotifications::class);
->registerNotifierService(AdminNotifications::class);
}

protected function registerUserInterface(): void {
Expand Down
9 changes: 1 addition & 8 deletions tests/Integration/app/appinfo/app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,4 @@
*
*/

\OC::$server->getNotificationManager()->registerNotifier(function() {
return new \OCA\NotificationsIntegrationTesting\Notifier();
}, function() {
return [
'id' => 'testing',
'name' => 'testing',
];
});
\OC::$server->getNotificationManager()->registerNotifierService(\OCA\NotificationsIntegrationTesting\Notifier::class);