Move unit and integration testing to github action #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
bye-travis
branch
from
1a672ae to
4aee771
Compare
nickvergessen
force-pushed
the
bye-travis
branch
3 times, most recently
from
6f2312c to
656e653
Compare
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bye-travis
branch
from
656e653 to
7f21395
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bye-travis
branch
from
782ac6b to
6dce4e7
Compare
Method getResponse may not return value of type Mock_IResponse_c6b56317, its return declaration is ": Psr\Http\Message\ResponseInterface" Signed-off-by: Joas Schilling <[email protected]>
skjnldsv
reviewed
Mar 26, 2021
| with: | ||
| php-version: ${{ matrix.php-versions }} | ||
| extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite | ||
| tools: phpunit:8.5.2 |
Member
There was a problem hiding this comment.
Maybe a bit wider? phpunit:8 ? If available 🤔
Member
Author
There was a problem hiding this comment.
copy pasta from somewhere, also the behat version needs to match.
I will try to get rid of the custom version with #901 when it works
skjnldsv
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]