Skip to content

Move unit and integration testing to github action #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 5 commits into from
Mar 26, 2021
Merged

Move unit and integration testing to github action #847

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9e56ee
Move unit and integration testing to github action
nickvergessen Jan 28, 2021
3c42355
Try starting the server in the action
nickvergessen Jan 28, 2021
7f21395
Fix php7.3 compatibility
nickvergessen Feb 15, 2021
6dce4e7
Split integration tests into separate actions
nickvergessen Mar 26, 2021
68dfa3f
Fix phpunit warning
nickvergessen Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix phpunit warning 
Method getResponse may not return value of type Mock_IResponse_c6b56317, its return declaration is ": Psr\Http\Message\ResponseInterface"

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Mar 26, 2021
commit 68dfa3f88d6086dae1f199a336b0fae260f9fc92
13 changes: 7 additions & 6 deletions tests/Unit/PushTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
use OCP\Notification\INotification;
use OCP\UserStatus\IManager as IUserStatusManager;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Http\Message\ResponseInterface;

/**
* Class PushTest
Expand Down Expand Up @@ -519,8 +520,8 @@ public function testPushToDeviceSending($isDebug) {
'level' => ILogger::ERROR,
]);

/** @var IResponse|MockObject $response1 */
$response1 = $this->createMock(IResponse::class);
/** @var ResponseInterface|MockObject $response1 */
$response1 = $this->createMock(ResponseInterface::class);
$response1->expects($this->once())
->method('getStatusCode')
->willReturn(Http::STATUS_BAD_REQUEST);
Expand All @@ -547,8 +548,8 @@ public function testPushToDeviceSending($isDebug) {
'app' => 'notifications',
]);

/** @var IResponse|MockObject $response1 */
$response2 = $this->createMock(IResponse::class);
/** @var ResponseInterface|MockObject $response1 */
$response2 = $this->createMock(ResponseInterface::class);
$response2->expects($this->once())
->method('getBody')
->willReturn('Maintenance');
Expand Down Expand Up @@ -586,8 +587,8 @@ public function testPushToDeviceSending($isDebug) {
])
->willReturn($response3);

/** @var IResponse|MockObject $response1 */
$response4 = $this->createMock(IResponse::class);
/** @var ResponseInterface|MockObject $response1 */
$response4 = $this->createMock(ResponseInterface::class);
$response4->expects($this->once())
->method('getStatusCode')
->willReturn(Http::STATUS_BAD_REQUEST);
Expand Down