Skip to content

[stable30] test: Fix location and navigation errors #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 3 commits into from
Apr 14, 2025
Merged

[stable30] test: Fix location and navigation errors #2926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c0b965
fix: Correctly handle abort error
artonge Apr 9, 2025
201f5f4
test: Wait for location to be saved
artonge Apr 9, 2025
023a2e8
chore(assets): Recompile assets
nextcloud-command Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Correctly handle abort error 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge @backportbot
artonge authored and backportbot[bot] committed Apr 9, 2025
commit 2c0b9657330113d827f553358455750193ee24f5
2 changes: 1 addition & 1 deletion src/mixins/FetchFilesMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export default {
logger.error('Fail to create source directory', { error })
}
}
} else if (error.code === 'ERR_CANCELED') {
} else if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
} else {
this.errorFetchingFiles = error
Expand Down
6 changes: 3 additions & 3 deletions src/services/Albums.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export async function fetchAlbum(path, options, extraProps = '', client = defaul

return formatAlbum(response.data)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return null
}

Expand Down Expand Up @@ -93,7 +93,7 @@ export async function fetchAlbums(path, options, extraProps = '', client = defau
.filter(album => album.filename !== path)
.map(formatAlbum)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down Expand Up @@ -163,7 +163,7 @@ export async function fetchAlbumContent(path, options, client = defaultClient) {

return fetchedFiles
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down
6 changes: 3 additions & 3 deletions src/services/collectionFetcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export async function fetchCollection(path, options, extraProps = [], client = d

return formatCollection(response.data)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return null
}

Expand Down Expand Up @@ -129,7 +129,7 @@ export async function fetchCollections(path, options, extraProps = [], client =
.filter(collection => collection.filename !== path)
.map(formatCollection)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down Expand Up @@ -200,7 +200,7 @@ export async function fetchCollectionFiles(path, options, extraProps = [], clien

return fetchedFiles
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down