Skip to content

[stable30] test: Fix location and navigation errors #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 3 commits into from
Apr 14, 2025
Merged

[stable30] test: Fix location and navigation errors #2926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c0b965
fix: Correctly handle abort error
artonge Apr 9, 2025
201f5f4
test: Wait for location to be saved
artonge Apr 9, 2025
023a2e8
chore(assets): Recompile assets
nextcloud-command Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cypress/e2e/albums.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ describe('Manage albums', () => {
it('Edit an album\'s name', () => {
cy.get('[aria-label="Open actions menu"]').click()
cy.contains('Edit album details').click()
cy.get('form [name="name"]').clear().type('New name')
cy.get('form [name="name"]').clear()
cy.get('form [name="name"]').type('New name')
cy.contains('Save').click()

cy.contains('New name')
Expand All @@ -108,15 +109,19 @@ describe('Manage albums', () => {

cy.get('[aria-label="Open actions menu"]').click()
cy.contains('Edit album details').click()
cy.get('form [name="name"]').clear().type('albums_test')
cy.get('form [name="name"]').clear()
cy.get('form [name="name"]').type('albums_test')
cy.contains('Save').click()
})

it('Edit an album\'s location', () => {
cy.get('[aria-label="Open actions menu"]').click()
cy.contains('Edit album details').click()
cy.get('form [name="location"]').clear().type('New location')
cy.get('form [name="location"]').clear()
cy.get('form [name="location"]').type('New location')
cy.intercept({ times: 1, method: 'PROPPATCH', url: '/remote.php/dav/photos/*/albums/*' }).as('propPatchAlbum')
cy.contains('Save').click()
cy.wait('@propPatchAlbum')

cy.contains('New location')

Expand Down
4 changes: 2 additions & 2 deletions js/photos-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-node_modules_vue-material-design-icons_ArrowLeft_vue-src_views_Timeline_vue.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-node_modules_vue-material-design-icons_ArrowLeft_vue-src_views_Timeline_vue.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-public.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-public.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_components_Collection_CollectionContent_vue-src_components_PhotosPicker_vue.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...os-src_components_Collection_CollectionContent_vue-src_components_PhotosPicker_vue.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_mixins_FetchCollectionContentMixin_js-src_components_HeaderNavigation_vue.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...otos-src_mixins_FetchCollectionContentMixin_js-src_components_HeaderNavigation_vue.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_mixins_FetchFilesMixin_js-src_components_Faces_FaceMergeForm_vue.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-src_mixins_FetchFilesMixin_js-src_components_Faces_FaceMergeForm_vue.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_views_Places_vue.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-src_views_Places_vue.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_views_SharedAlbums_vue.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-src_views_SharedAlbums_vue.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/mixins/FetchFilesMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export default {
logger.error('Fail to create source directory', { error })
}
}
} else if (error.code === 'ERR_CANCELED') {
} else if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
} else {
this.errorFetchingFiles = error
Expand Down
6 changes: 3 additions & 3 deletions src/services/Albums.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export async function fetchAlbum(path, options, extraProps = '', client = defaul

return formatAlbum(response.data)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return null
}

Expand Down Expand Up @@ -93,7 +93,7 @@ export async function fetchAlbums(path, options, extraProps = '', client = defau
.filter(album => album.filename !== path)
.map(formatAlbum)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down Expand Up @@ -163,7 +163,7 @@ export async function fetchAlbumContent(path, options, client = defaultClient) {

return fetchedFiles
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down
6 changes: 3 additions & 3 deletions src/services/collectionFetcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export async function fetchCollection(path, options, extraProps = [], client = d

return formatCollection(response.data)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return null
}

Expand Down Expand Up @@ -129,7 +129,7 @@ export async function fetchCollections(path, options, extraProps = [], client =
.filter(collection => collection.filename !== path)
.map(formatCollection)
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down Expand Up @@ -200,7 +200,7 @@ export async function fetchCollectionFiles(path, options, extraProps = [], clien

return fetchedFiles
} catch (error) {
if (error.code === 'ERR_CANCELED') {
if (error instanceof DOMException && error.code === error.ABORT_ERR) {
return []
}

Expand Down
Loading