Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Jun 18, 2025

Follow-ups of #3003
Fix #3027

  • Move display of filters in album content view to the album edition form
  • Use cog icon instead of the filter icon
  • Replace filter icon button in timeline, with a button saying "Filters" Not needed any more due to the move to the navigation sidebar
  • Don't reload when hiding filters without filters Not needed any more due to the move to the navigation sidebar
  • Merge filters inputs into one main input placed at the top of the left sidebar

Todos

  • Adapt/extend Cypress tests

Screenshots

Context Screenshots
Filtering the timeline Screenshot From 2025-06-20 13-00-40
Creating an album based on the filters image
Display and editing filters of an album image

@artonge artonge added this to the Nextcloud 32 milestone Jun 18, 2025
@artonge artonge self-assigned this Jun 18, 2025
@artonge artonge added enhancement New feature or request javascript Javascript related ticket 2. developing Work in progress labels Jun 18, 2025
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.24%. Comparing base (ca0afbe) to head (ef9fe39).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3085      +/-   ##
=========================================
- Coverage    2.28%   2.24%   -0.04%     
=========================================
  Files         108     107       -1     
  Lines        6441    6504      +63     
  Branches      122     121       -1     
=========================================
- Hits          147     146       -1     
- Misses       6289    6353      +64     
  Partials        5       5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 20, 2025
@artonge artonge force-pushed the artonge/feat/unify_filter_input branch from d037626 to 20cdb1a Compare June 20, 2025 13:00
@artonge artonge marked this pull request as ready for review June 20, 2025 13:00
@artonge artonge force-pushed the artonge/feat/unify_filter_input branch 4 times, most recently from 66aed3f to f269ca4 Compare June 20, 2025 14:49
@artonge artonge requested review from skjnldsv and susnux August 18, 2025 13:20
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work 👍

And run cs:fix

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/unify_filter_input branch from f269ca4 to ef9fe39 Compare August 18, 2025 16:10
@artonge artonge merged commit 5cd8975 into master Aug 18, 2025
56 of 63 checks passed
@artonge artonge deleted the artonge/feat/unify_filter_input branch August 18, 2025 17:03
@skjnldsv skjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to create Smart Albums based on filters

4 participants