Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented May 7, 2025

Additions

  • Allow associating filters to albums
  • Populate filters based on the filters. Also work in shared and public albums.
  • Display filters in album form
  • Display filters in album content view
  • Allow edition of filters in album content view
  • Denote albums with filters in the albums list
  • Use a random picture from the filtered photo as cover picture
  • Forbid to remove a filtered picture
  • Add E2E testing of the of filters with albums

Other goodies

  • Minor refactoring of the DAV API to ease the addition of new feature
  • E2E testing of the DAV API

Limitations

  • Filtered pictures in albums are limited to 1000. We need a limit for the search query, 1000 is arbitrary

Follow-ups

  • Move display of filters in album content view to the album edition form
  • Use cog icon instead of the filter icon
  • Replace filter icon button in timeline, with a button saying "Filters"
  • Don't reload when hiding filters without filters
  • Merge filters inputs into one main input placed at the top of the left sidebar
  • Add warning in frontend about 1000 picture limit

Screenshots

Context Screenshots
Creating an album from filters Screenshot From 2025-05-22 15-19-17
Album form with a summary of the filters Screenshot From 2025-05-22 15-19-34
Albums list uses random pictures from the filtered pictures. Albums with filters are denoted with an icon Screenshot From 2025-05-22 15-23-26
Filters summary is displayed in the album content view Screenshot From 2025-05-22 15-20-14
Removing a filtered picture is not possible Screenshot From 2025-05-22 15-20-25

References

Partially addresses:

@artonge artonge requested a review from skjnldsv as a code owner May 7, 2025 16:59
@artonge artonge self-assigned this May 7, 2025
@artonge artonge removed the request for review from skjnldsv May 7, 2025 16:59
@artonge artonge added enhancement New feature or request php PHP related ticket javascript Javascript related ticket 2. developing Work in progress labels May 7, 2025
@artonge artonge added this to the Nextcloud 32 milestone May 7, 2025
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.35%. Comparing base (02a40c9) to head (94d2210).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3003      +/-   ##
=========================================
+ Coverage    2.28%   2.35%   +0.07%     
=========================================
  Files         104     108       +4     
  Lines        6355    6328      -27     
  Branches      118     122       +4     
=========================================
+ Hits          145     149       +4     
+ Misses       6206    6175      -31     
  Partials        4       4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge marked this pull request as draft May 7, 2025 17:04
@artonge artonge force-pushed the artonge/feat/create_album_based_on_filters branch 4 times, most recently from 00298bd to d91a718 Compare May 16, 2025 14:49
@artonge artonge force-pushed the artonge/feat/create_album_based_on_filters branch from 009addf to 82d2244 Compare May 22, 2025 09:11
artonge added 14 commits May 22, 2025 12:19
Reduce the amount of intermediate variables and watchers.
React to filters change from the parent component
Rename to "Photos" filters as it can be used in others places

Signed-off-by: Louis Chemineau <[email protected]>
And remove unused Navigation component.

Signed-off-by: Louis Chemineau <[email protected]>
Take the opportunity to create use functions and share logic between the input and the display

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/create_album_based_on_filters branch from 2609df3 to c734c48 Compare May 22, 2025 10:35
@artonge artonge marked this pull request as ready for review May 22, 2025 13:36
@artonge artonge added the 3. to review Waiting for reviews label May 22, 2025
@artonge artonge requested review from skjnldsv and susnux May 22, 2025 13:38
@artonge artonge force-pushed the artonge/feat/create_album_based_on_filters branch from 40d66dc to 94d2210 Compare May 22, 2025 13:41
@artonge artonge removed the 2. developing Work in progress label May 22, 2025
@artonge artonge merged commit f790f60 into master May 27, 2025
50 checks passed
@artonge artonge deleted the artonge/feat/create_album_based_on_filters branch May 27, 2025 14:39
@AndyScherzinger AndyScherzinger moved this from 🏗️ In progress to ☑️ Done in 📁 Files team May 27, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team May 27, 2025
@Antreesy
Copy link

Antreesy commented Jun 4, 2025

App upgrade and fresh instance installation fails for me locally, supposedly from this PR:

image
nextcloud-1  | In MigrationService.php line 481:
nextcloud-1  |
nextcloud-1  |   Migration step 'OCA\Photos\Migration\Version32000Date20250507132617' is unk
nextcloud-1  |   nown
nextcloud-1  |
nextcloud-1  |
nextcloud-1  | maintenance:install [--database DATABASE] [--database-name DATABASE-NAME] [--database-host DATABASE-HOST] [--database-port DATABASE-PORT] [--database-user DATABASE-USER] [--database-pass [DATABASE-PASS]] [--database-table-space [DATABASE-TABLE-SPACE]] [--admin-user ADMIN-USER] [--admin-pass ADMIN-PASS] [--admin-email [ADMIN-EMAIL]] [--data-dir DATA-DIR]
nextcloud-1  |
nextcloud-1  | Nextcloud is not installed - only a limited number of commands are available
nextcloud-1  | Last nextcloud.log entry:
nextcloud-1  |
nextcloud-1  | =======================================================================================
nextcloud-1  | 🚨 Server installation failed.
nextcloud-1  | =======================================================================================

@artonge
Copy link
Collaborator Author

artonge commented Jun 4, 2025

Can you run composer i inside photos?

@Antreesy
Copy link

Antreesy commented Jun 4, 2025

That helped, thanks! That's a local-only history, package users / customers shouldn't later stuck on it?

@artonge
Copy link
Collaborator Author

artonge commented Jun 4, 2025

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php PHP related ticket 🍂 2025-Autumn

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

5 participants