Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Oct 9, 2025

Two issues:

  1. The viewer was failing to build the Node because /files/admin was not included in the source. In the album view, the nodes' source are base on the albums DAV endpoint.
  2. Even if the viewer was able to build that Node object, the delete request was only removing the photo from the album and not from the user's file system, as it was targeting the albums DAV endpoint.

Solution: give the real source to the viewer.

Then there are two other commits to:

  1. React to the files:node:deleted event
  2. Reset the selection on submit in the PhotosPicker

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.22%. Comparing base (dfdbd3c) to head (8089f34).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3217      +/-   ##
=========================================
- Coverage    2.23%   2.22%   -0.01%     
=========================================
  Files         107     107              
  Lines        6530    6556      +26     
  Branches      121     121              
=========================================
  Hits          146     146              
- Misses       6379    6405      +26     
  Partials        5       5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge
Copy link
Collaborator Author

artonge commented Oct 9, 2025

/backport to stable32

@artonge
Copy link
Collaborator Author

artonge commented Oct 9, 2025

/backport to stable31

@artonge
Copy link
Collaborator Author

artonge commented Oct 9, 2025

/backport to stable30

@artonge artonge self-assigned this Oct 9, 2025
@artonge artonge added bug Something isn't working enhancement New feature or request php PHP related ticket javascript Javascript related ticket feature: albums Related to the albums section labels Oct 9, 2025
@artonge artonge added this to the Nextcloud 33 milestone Oct 9, 2025
@artonge artonge added the 2. developing Work in progress label Oct 9, 2025
@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Oct 9, 2025
@artonge artonge force-pushed the artonge/feat/react_to_deleted_event branch from a8d87c7 to 4323b75 Compare October 9, 2025 15:33
@artonge artonge changed the title feat(FilesListViewer): React to files:node:deleted event feat(Albums): Allow deleting an album photo from the viewer Oct 9, 2025
@artonge artonge requested review from skjnldsv and susnux October 9, 2025 16:05
@artonge artonge force-pushed the artonge/feat/react_to_deleted_event branch 2 times, most recently from 0bdb355 to 9dbdfa4 Compare October 9, 2025 16:16
This removes the files from the list if it was deleted from the Viewer

Signed-off-by: Louis Chmn <[email protected]>
@artonge artonge force-pushed the artonge/feat/react_to_deleted_event branch from 9dbdfa4 to d39dbfc Compare October 9, 2025 16:21
@artonge
Copy link
Collaborator Author

artonge commented Oct 10, 2025

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge requested a review from nfebe October 10, 2025 14:11
@artonge artonge merged commit b3ade68 into master Oct 14, 2025
48 of 49 checks passed
@artonge artonge deleted the artonge/feat/react_to_deleted_event branch October 14, 2025 12:27
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug Something isn't working enhancement New feature or request feature: albums Related to the albums section javascript Javascript related ticket php PHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants