-
-
Notifications
You must be signed in to change notification settings - Fork 77
feat(Albums): Allow deleting an album photo from the viewer #3217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3217 +/- ##
=========================================
- Coverage 2.23% 2.22% -0.01%
=========================================
Files 107 107
Lines 6530 6556 +26
Branches 121 121
=========================================
Hits 146 146
- Misses 6379 6405 +26
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/backport to stable32 |
Collaborator
Author
|
/backport to stable31 |
Collaborator
Author
|
/backport to stable30 |
a8d87c7 to
4323b75
Compare
files:node:deleted event0bdb355 to
9dbdfa4
Compare
This removes the files from the list if it was deleted from the Viewer Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
9dbdfa4 to
d39dbfc
Compare
Signed-off-by: Louis Chmn <[email protected]>
Collaborator
Author
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
susnux
approved these changes
Oct 14, 2025
CarlSchwan
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
bug
Something isn't working
enhancement
New feature or request
feature: albums
Related to the albums section
javascript
Javascript related ticket
php
PHP related ticket
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues:
Nodebecause/files/adminwas not included in the source. In the album view, the nodes' source are base on the albums DAV endpoint.Solution: give the real source to the viewer.
Then there are two other commits to:
files:node:deletedeventPhotosPickeridinstead offileidtoFileconstructor viewer#2988 as the Viewer does not use the right property for the file id when building theNodeobject.