fix(Viewer): Provide id instead of fileid to File constructor
#2988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
artonge
added
bug
artonge
force-pushed
the
artonge/fix/do_not_provide_root
branch
from
ab392ee to
c1b6f63
Compare
artonge
force-pushed
the
artonge/fix/do_not_provide_root
branch
from
c1b6f63 to
00dcda1
Compare
artonge
force-pushed
the
artonge/fix/do_not_provide_root
branch
2 times, most recently
from
237dd8d to
2336ad8
Compare
The `Node` object uses the `id` property in the `fileid` getter: https://github.com/nextcloud-libraries/nextcloud-files/blob/62c497479945f84249366690310ff1180198f85b/lib/node/node.ts#L331-L332 Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
artonge/fix/do_not_provide_root
branch
from
2336ad8 to
417df0b
Compare
artonge
added
3. to review
skjnldsv
approved these changes
Oct 10, 2025
JuliaKirschenheuter
approved these changes
Oct 10, 2025
Contributor
Author
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
susnux
approved these changes
Oct 10, 2025
artonge
force-pushed
the
artonge/fix/do_not_provide_root
branch
from
5dccc12 to
a487e3b
Compare
Contributor
Author
|
CI broken due to the previews changes in server. Can be forced merged |
artonge
added
4. to release
Member
Can you clarify which changes ? |
backportbot
bot
removed
the
backport-request
Contributor
Author
This change: nextcloud/server#54543 |
artonge
added a commit
that referenced
this pull request
Oct 14, 2025
- Follow-up of #2988 Signed-off-by: Louis Chmn <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
- Follow-up of #2988 Signed-off-by: Louis Chmn <[email protected]> [skip ci]
artonge
added a commit
that referenced
this pull request
Oct 15, 2025
- Follow-up of #2988 Signed-off-by: Louis Chmn <[email protected]> [skip ci]
Contributor
Author
|
/backport to stable29 |
2 tasks
backportbot
bot
removed
the
backport-request
artonge
added a commit
that referenced
this pull request
Nov 14, 2025
- Follow-up of #2988 Signed-off-by: Louis Chmn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Nodeobject uses theidproperty in thefileidgetter: https://github.com/nextcloud-libraries/nextcloud-files/blob/62c497479945f84249366690310ff1180198f85b/lib/node/node.ts#L331-L332