Skip to content

Fix spacing for thumbnails and recommendations list #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Dec 10, 2019
Merged

Fix spacing for thumbnails and recommendations list #156

ChristophWurst merged 1 commit into from
Dec 10, 2019

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Dec 10, 2019

Before

  • Text of the bottom row was cut off
  • Entries had small clickable area, felt cramped
  • No padding to left of thumbnail
    Recommendations before

After

Recommendations after

Please review @ChristophWurst @nextcloud/designers

@jancborchardt jancborchardt added bug Something isn't working 3. to review design labels Dec 10, 2019
@jancborchardt jancborchardt added this to the Nextcloud 18 milestone Dec 10, 2019
ChristophWurst
ChristophWurst requested changes Dec 10, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, thanks!

Please build the artifacts and commit them :)

marcoambrosini
marcoambrosini approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 10, 2019 •
edited by gary-kim
Loading

/compile amend /

1 similar comment
@gary-kim
Copy link
Member

gary-kim commented Dec 10, 2019

/compile amend /

@gary-kim
Copy link
Member

gary-kim commented Dec 10, 2019

Huh, @jancborchardt mind if I rebase?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 10, 2019

Huh, @jancborchardt mind if I rebase?

do it :)

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 10, 2019 •
edited
Loading

@jancborchardt jancborchardt mentioned this pull request Dec 10, 2019
Merged
@jancborchardt
Copy link
Member Author

jancborchardt commented Dec 10, 2019

Huh, @jancborchardt mind if I rebase?

Not at all, thanks! :)

@ChristophWurst I added a note about committing the build artifacts: #157

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 10, 2019

@jancborchardt rebase

@jancborchardt
Copy link
Member Author

jancborchardt commented Dec 10, 2019

@jancborchardt rebase

Done! Hope it’s all good now? :D

ChristophWurst
ChristophWurst approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ChristophWurst ChristophWurst merged commit 631ff38 into master Dec 10, 2019
@ChristophWurst ChristophWurst deleted the design/fix-spacing branch December 10, 2019 13:29
@rullzer rullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@gary-kim gary-kim gary-kim approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to release bug Something isn't working design

Projects

None yet

Milestone

Nextcloud 18

Development

Successfully merging this pull request may close these issues.

6 participants

@jancborchardt @ChristophWurst @gary-kim @skjnldsv @marcoambrosini