Skip to content

Register login option via public API #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Jul 21, 2020
Merged

Register login option via public API #230

nickvergessen merged 2 commits into from
Jul 21, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 14, 2020 •
edited
Loading

ChristophWurst
ChristophWurst requested changes Jul 14, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we just add this as registration option to the registration context?

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 14, 2020

Ref nextcloud/server#21828

@nickvergessen nickvergessen force-pushed the techdebt/noid/use-event-to-register-login-option branch from aeb42d9 to 086b8e3 Compare July 16, 2020 08:44
@nickvergessen nickvergessen changed the title Use the event to register the login option Register login option via public API Jul 16, 2020
ChristophWurst
ChristophWurst approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@nickvergessen nickvergessen mentioned this pull request Jul 16, 2020
Merged
@nickvergessen nickvergessen force-pushed the techdebt/noid/use-event-to-register-login-option branch from 4731457 to 832f619 Compare July 16, 2020 10:44
@nickvergessen nickvergessen force-pushed the techdebt/noid/use-event-to-register-login-option branch from 832f619 to 650e313 Compare July 21, 2020 18:23
@nickvergessen nickvergessen merged commit eb41b6f into master Jul 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the techdebt/noid/use-event-to-register-login-option branch July 21, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to review technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @ChristophWurst