Allow to register AlternativeLogin on RegistrationContext #21850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Jul 15, 2020
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Good from an API PoV
Terrible internally. The static stuff hurts :P
Member
Author
|
We can kill it when we don't care about bc, fine by me |
Member
Author
|
Sample implementation at nextcloud/registration#230 |
2 tasks
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/register-alternative-logins
branch
from
5d4bd4b to
0dfcc13
Compare
nickvergessen
added
3. to review
MorrisJobke
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]