Fix: allow opening PDF with Collabora #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raudius
added
enhancement
Raudius
requested review from
julien-nc and
juliusknorr
and removed request for
julien-nc
juliusknorr
reviewed
Jul 6, 2022
juliusknorr
reviewed
Jul 6, 2022
julien-nc
previously requested changes
Jul 13, 2022
juliusknorr
reviewed
Jul 21, 2022
css/filetypes.scss
Outdated
| filter: var(--background-invert-if-dark); | ||
| } | ||
|
|
||
| body.dark .icon-richdocuments { |
Member
There was a problem hiding this comment.
Let's drop it since we have one branch per major Nextcloud version ;)
Contributor
Author
There was a problem hiding this comment.
Done! We will add it manually for the backports?
Raudius
force-pushed
the
enh/fix_context_menu
branch
2 times, most recently
from
29211ac to
959a538
Compare
Signed-off-by: Raul <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Raudius
force-pushed
the
enh/fix_context_menu
branch
from
959a538 to
b65dc89
Compare
juliusknorr
approved these changes
Jul 26, 2022
Member
|
@Raudius Mind to take care of the backport manually as it needs adjustments anyways as you stated above? |
This was referenced Jul 27, 2022
Member
|
Already back ported manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regression where PDFs could not be opened with collabora since we moved to using the Viewer app (#1820).
Adds the context menu option to edit PDFs, and registers the actions with the files app. For the action handler we call the new viewer method
openWith(nextcloud/viewer#1273).TODO
openWithfunction to OCA.Viewer viewer#1273Checklist