Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 21, 2021

This PR adapts the file display of Collabora to the new full screen mode by switching from the legacy viewer.js to use the viewer app instead. In addition it addresses some default handling like passing over the classic ui mode and making the notebookbar configurable through app config.

Further small enhancements:

@juliusknorr juliusknorr added this to the 5.0.0 milestone Oct 21, 2021
@juliusknorr juliusknorr added 2. developing Work in progress enhancement New feature or request labels Oct 21, 2021
@juliusknorr juliusknorr added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Nov 10, 2021
@juliusknorr juliusknorr marked this pull request as ready for review November 10, 2021 12:13
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use light viewer mode: 👍 Very nice. One small problem though: The viewer sidebar button and the Collabora sidebar button overlaps when Collabora's menu is hidden via the top-right arrow button. Not a big deal.

  • Pass over more css variables to collabora: 👍

  • Temporary avatar listing display overlaying Collabora: Very nice too. The avatars are not aligned with the Collabora top-right close button. Maybe we could make this button the same size than the avatars and the viewer's sidebar button.

  • Start using inital state for passing document data to the frontend code: 👍

Is the classic Collabora menu used intentionally instead of the ribbon one?

@juliusknorr
Copy link
Member Author

Is the classic Collabora menu used intentionally instead of the ribbon one?

Yes, that was discussed before with @jancborchardt

@julien-nc julien-nc self-requested a review November 10, 2021 14:27
@juliusknorr juliusknorr merged commit 694dc40 into master Nov 10, 2021
@juliusknorr juliusknorr deleted the enh/ui branch November 10, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants