-
Notifications
You must be signed in to change notification settings - Fork 138
UI rework #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI rework #1820
Conversation
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Use light viewer mode: 👍 Very nice. One small problem though: The viewer sidebar button and the Collabora sidebar button overlaps when Collabora's menu is hidden via the top-right arrow button. Not a big deal.
-
Pass over more css variables to collabora: 👍
-
Temporary avatar listing display overlaying Collabora: Very nice too. The avatars are not aligned with the Collabora top-right close button. Maybe we could make this button the same size than the avatars and the viewer's sidebar button.
-
Start using inital state for passing document data to the frontend code: 👍
Is the classic Collabora menu used intentionally instead of the ribbon one?
Yes, that was discussed before with @jancborchardt |
This PR adapts the file display of Collabora to the new full screen mode by switching from the legacy viewer.js to use the viewer app instead. In addition it addresses some default handling like passing over the classic ui mode and making the notebookbar configurable through app config.
Further small enhancements: