Skip to content

Listen for event during preview rendering and apply secure view options #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Oct 26, 2022
Merged

Listen for event during preview rendering and apply secure view options #2579

juliusknorr merged 2 commits into from
Oct 26, 2022

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 25, 2022 •
edited
Loading

Summary

  • Refactor watermark (secure view) checks to actually check against the node/share permissions
  • Add option to enforce watermarks on disabled download shares (internal)
  • Add listener to disable previews of hide download share links
  • Clarify what secure view does in the settings (see screenshot)

Screenshot 2022-10-26 at 16 19 43

@juliusknorr juliusknorr force-pushed the bugfix/watermark-preview branch 3 times, most recently from 0c1eaa2 to 4970eb1 Compare October 26, 2022 11:57
@juliusknorr juliusknorr force-pushed the bugfix/watermark-preview branch from 4970eb1 to fc9cbbd Compare October 26, 2022 14:17
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Oct 26, 2022
Raudius
Raudius approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@Raudius Raudius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Only thing I noticed is that you close a read-only watermarked file, you get a pretty bare view.

Screenshot:

image

Might be something to look into with the design team after this PR is merged :)

@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 26, 2022

Let me actually have a look at that, because closing is something we can probably disable in the collabora view :)

@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 26, 2022

Might need some extra backend handling to hand over if we are on a single or folder share, will open a follow up issue for that.

@juliusknorr juliusknorr merged commit d03fa73 into master Oct 26, 2022
@juliusknorr juliusknorr deleted the bugfix/watermark-preview branch October 26, 2022 19:51
@juliusknorr juliusknorr mentioned this pull request Oct 26, 2022
Closed
@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 26, 2022

/backport to stable25

@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 26, 2022

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 26, 2022
Merged
1 task
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 26, 2022
Merged
1 task
@juliusknorr juliusknorr mentioned this pull request Nov 21, 2022
Closed
@joshtrichards joshtrichards mentioned this pull request Oct 22, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raudius Raudius Raudius approved these changes

@marcelklehr marcelklehr Awaiting requested review from marcelklehr

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

No one assigned

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @Raudius