Skip to content

Emit typed event when preview is requested #34799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Oct 27, 2022
Merged

Emit typed event when preview is requested #34799

skjnldsv merged 1 commit into from
Oct 27, 2022

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 25, 2022 •
edited
Loading

Adds a typed event in order to replace the deprecated event that is already in place.

@juliusknorr juliusknorr mentioned this pull request Oct 25, 2022
Merged
1 task
@juliusknorr juliusknorr force-pushed the bugfix/noid/preview-event branch 2 times, most recently from dfbaf31 to 055c787 Compare October 26, 2022 13:33
@juliusknorr juliusknorr marked this pull request as ready for review October 26, 2022 14:17
@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels Oct 26, 2022
@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 26, 2022

/backport to stable25

@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 26, 2022

/backport to stable24

@juliusknorr juliusknorr requested a review from julien-nc October 26, 2022 14:25
marcelklehr
marcelklehr reviewed Oct 26, 2022
View reviewed changes
@juliusknorr juliusknorr force-pushed the bugfix/noid/preview-event branch from 055c787 to 9c011b3 Compare October 27, 2022 09:09
PVince81
PVince81 approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2022
This was referenced Oct 27, 2022
Merged
Merged
ChristophWurst
ChristophWurst approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🤔

@skjnldsv
Copy link
Member

skjnldsv commented Oct 27, 2022

@juliushaertl can you address Christoph Wurst MSc's comment if you want this in today 😉

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 27, 2022
@juliusknorr juliusknorr force-pushed the bugfix/noid/preview-event branch from 9c011b3 to 07e94ec Compare October 27, 2022 12:31
@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 27, 2022
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2022
@juliusknorr juliusknorr enabled auto-merge October 27, 2022 12:47
@skjnldsv skjnldsv disabled auto-merge October 27, 2022 13:38
@skjnldsv skjnldsv merged commit 5b77675 into master Oct 27, 2022
@skjnldsv skjnldsv deleted the bugfix/noid/preview-event branch October 27, 2022 13:38
This was referenced Oct 27, 2022
Merged
Merged
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 27, 2022
@juliusknorr juliusknorr mentioned this pull request Nov 21, 2022
Closed
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 7, 2023

This event is missing on https://docs.nextcloud.com/server/latest/developer_manual/basics/events.html#available-events

@juliusknorr juliusknorr mentioned this pull request Jun 8, 2023
Merged
@juliusknorr juliusknorr removed the pending documentation This pull request needs an associated documentation update label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@Raudius Raudius Awaiting requested review from Raudius

@julien-nc julien-nc Awaiting requested review from julien-nc

@marcelklehr marcelklehr Awaiting requested review from marcelklehr

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@juliusknorr @skjnldsv @ChristophWurst @nickvergessen @PVince81 @marcelklehr