Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 10, 2024

This is a minimal invasive backport of the parts of #3315 that allow configuring a separate callback URL for WOPI that can be used to use a different URL for requests Collabora is performing towards Nextcloud

occ config:app:set richdocuments wopi_callback_url --value="http://stable27"

@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Apr 10, 2024
@juliusknorr juliusknorr requested review from blizzz and elzody April 10, 2024 09:07
@cypress
Copy link

cypress bot commented Apr 10, 2024

Passing run #803 ↗︎

0 31 0 0 Flakiness 0

Details:

[stable27] fix: Allow configuring the wopi_callback_url
Project: Richdocuments Commit: c8814efb74
Status: Passed Duration: 02:57 💡
Started: Apr 10, 2024 3:33 PM Ended: Apr 10, 2024 3:36 PM

Review all test suite changes for PR #3575 ↗︎

@juliusknorr juliusknorr force-pushed the fix/internal-url-stable27 branch from c5aa861 to 16d4aa3 Compare April 10, 2024 10:06
@blizzz blizzz changed the title fix: Allow configuring the wopi_callback_url [stable27] fix: Allow configuring the wopi_callback_url Apr 10, 2024
}

const getWopiSrc = (fileId) => {
// WOPISrc - URL that loolwsd will access (ie. pointing to ownCloud)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 for the sake of backport 🍸

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Updated

Copy link
Member

@blizzz blizzz Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought it is kept intentionally to not have differences with higher branches

@juliusknorr juliusknorr force-pushed the fix/internal-url-stable27 branch from 16d4aa3 to e2ff3b7 Compare April 10, 2024 15:29
@juliusknorr juliusknorr force-pushed the fix/internal-url-stable27 branch from e2ff3b7 to c8814ef Compare April 10, 2024 15:30
@juliusknorr juliusknorr merged commit f3dd044 into stable27 Apr 11, 2024
@delete-merged-branch delete-merged-branch bot deleted the fix/internal-url-stable27 branch April 11, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants