fix: Use wopi callback url for all urls handed over to Collabora #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
commented
Apr 12, 2024
|
|
||
| const getWopiSrc = (fileId) => { | ||
| // WOPISrc - URL that loolwsd will access (ie. pointing to ownCloud) | ||
| // WOPISrc - URL that Collabora will use to access Nextcloud |
Member
Author
blizzz
approved these changes
Apr 12, 2024
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
nitpick: URL generation can be put in an new short method, so the next time it needs just only one adjustment. Not a blocker.
juliusknorr
force-pushed
the
fix/wopi-callback-url
branch
2 times, most recently
from
40fad16 to
2f82662
Compare
Member
Author
|
Cypress failure seems related, will check |
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/wopi-callback-url
branch
from
2f82662 to
2cc2536
Compare
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3579
Some URLs were not respecting the wopi_callback_url setting that we have in place now to configure the URL that Collabora will use to talk to Nextcloud, so this PR adapts those.