Unable to delete User_LDAP user files/shares

[andrius-kulbis]

Steps to reproduce

1. Setup User_LDAP app to use LDAP backend
2. Delete user from LDAP
3. Delete user via occ user:delete

Expected behaviour

User, his all data and shares removed.

Actual behaviour

User is visible in ldap:show-remnants output.

If LDAP cache is expired and does not contain a deleted user anymore, the user:delete operation fails saying that the user does not exists (while his files and shares are still present). User shares become broken but visible (not able to access them or unshare them)

Server configuration

Operating system: Debian Jessie

Web server: Apache 2.4

Database: Mariadb 10

PHP version: 5.6.27

Nextcloud version: 11.0.2

Updated from an older Nextcloud/ownCloud or fresh install: updated

Where did you install Nextcloud from: updater

Are you using an external user-backend, if yes which one: LDAP

Nextcloud log (data/nextcloud.log)

Nextcloud log

While accessing share of user deleted from ldap:

{"reqId":"QM4KjOpNF9hTWTdYc\/IK","remoteAddr":"127.0.0.1","app":"files","message":" Backends provided no user object for testuser","level":3,"time":"2017-03-28T11:06:07+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=test.csv&dir=%2F","user":"user","version":"11.0.2.7"}

[4001982248998]

I also might have that problem.

Checking a user account presence:

user@host:~$ occ ldap:check-user 621D38FD-13C8-4D18-9C8A-40E361ED2ABD
The user does not exists on LDAP anymore.
Clean up the user's remnants by: ./occ user:delete "621D38FD-13C8-4D18-9C8A-40E361ED2ABD"

Then trying to delete it:

user@host:~$ occ user:delete "621D38FD-13C8-4D18-9C8A-40E361ED2ABD"

                                                                    
  [OC\User\NoUserException]                                         
  621D38FD-13C8-4D18-9C8A-40E361ED2ABD is not a valid user anymore  
                                                                    

user:delete <uid>

Log excerpt:

{"reqId":"nTR4oUvYXrN6I0aTtt6h","level":3,"time":"2017-05-30T09:55:51+00:00","remoteAddr":"","user":"--","app":"PHP","method":"--","url":"--","message":"ldap_start_tls(): Unable to start TLS: Server is unavailable at \/var\/www\/nextcloud\/apps\/user_ldap\/lib\/LDAP.php#293","userAgent":"--","version":"12.0.0.29"}

The LDAP server is present, however, and LDAP logons possible.

[bcoory]

+1

[blizzz]

Introduced by #2845

The early fetching of the home directory caused that one property was not set – this happens on deleteUser(). And caused an Exception to be thrown. It's stupid to depend on this behaviour however. I believe we have had this weird way to know that there is a delete operation, and avoid other cases… but if so, the case is not documented.

[blizzz]

I believe we have had this weird way to know that there is a delete operation, and avoid other cases… but if so, the case is not documented.

Actually there is a test for it and it's a challenge…

[blizzz]

Fix in #5689