LDAP: simplify returning the homePath and fixing #4117 #5689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5689 +/- ##
=============================================
+ Coverage 30.54% 53.88% +23.33%
- Complexity 22497 25219 +2722
=============================================
Files 1403 1420 +17
Lines 87079 96613 +9534
Branches 1327 1402 +75
=============================================
+ Hits 26601 52059 +25458
+ Misses 60478 44554 -15924
|
blizzz
force-pushed
the
fix-4117
branch
2 times, most recently
from
b67513c to
f542e80
Compare
blizzz
added
3. to review
Member
Author
|
Please review @nextcloud/ldap |
homesToKill was not set in runtime since some changes some place else. It required deleteUser() to be called first. The method acts independent of it now. Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Member
Author
|
rebased |
Member
Author
|
Still looking for reviewers :) |
rullzer
approved these changes
Sep 13, 2017
MorrisJobke
approved these changes
Sep 13, 2017
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and LDAP setup still works 👍
Member
Author
|
thx :) ❤️ i do the backport tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a downstream PR came a change in the user deletion process that rendered cleanup in LDAP broker. Key issue was the
getHome()method. On cleaning up, it needs to return the user folder, but otherwise should throw an Exception.This PR fixes it in a more reliable way. (It could have been more beautiful but it ate already too much time :( cannot spend more on refactoring )
Needs to be backported for 12.
Fixes #4117