Fix drag shadow in Files app #10892
Merged
Fix drag shadow in Files app #10892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The drag shadow is a sibling of "#content" so its z-index must be higher than the z-index of the content children (navigation bar, app content and app sidebar) to appear in front of them. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The general file list sets "max-width: 0" in the file names, which causes the file names in the drag shadow to have no width for their content and thus to overlap with the file size. As that limit is needed for proper layout in the general file list it is removed only for file names in drag shadows. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
bug
design
juliusknorr
approved these changes
Aug 28, 2018
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Works as expected and the fix for Safari is still applying.
skjnldsv
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the increased 'z-index` in the content children the drag shadow was no longer visible.
Besides that, once the drag shadow was made visible again the file size overlapped the file name. This was caused by
max-width: 0set for file names, which was introduced in cbdaa8b; as it is necessary for the general file list that limit is removed only for file names in drag shadows.How to test:
-Open the Files app
-Drag a file (press down with the mouse on the file and move it) anywhere
Expected result:
The file name and its size follow the cursor when it is moved
Actual result:
No element follows the cursor while the file is being dragged