Skip to content

Fix drag shadow in Files app #10892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Aug 28, 2018
Merged

Fix drag shadow in Files app #10892

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8824af3
Increase z-index of drag shadow for files
danxuliu Aug 27, 2018
c3610d1
Remove limit on "max-width" for file names in drag shadow
danxuliu Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove limit on "max-width" for file names in drag shadow 
The general file list sets "max-width: 0" in the file names, which
causes the file names in the drag shadow to have no width for their
content and thus to overlap with the file size.

As that limit is needed for proper layout in the general file list it is
removed only for file names in drag shadows.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Aug 27, 2018
commit c3610d1d172d49601e4cb688f0ec5b90c35ac09d
3 changes: 3 additions & 0 deletions apps/files/css/files.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,9 @@ table.dragshadow td.filename {
padding-left:60px;
padding-right:16px;
height: 36px;

/* Override "max-width: 0" to prevent file name and size from overlapping */
max-width: unset;
}
table.dragshadow td.size {
padding-right:8px;
Expand Down