204 and 304 must not have a body, see https://tools.ietf.org/html/rfc… #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blizzz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @MorrisJobke to be potential reviewers |
| if ($this->getStatus() === Http::STATUS_NO_CONTENT | ||
| || $this->getStatus() === Http::STATUS_NOT_MODIFIED | ||
| ) { | ||
| $response = null; |
Member
There was a problem hiding this comment.
I'd say we should only take this for master and then throw an exception. Don't do magic.
Member
|
This fix is the wrong way around. So 👎 |
Member
|
Also it is weird that it only does this for 1 response type |
Member
Author
|
Then, let's 🔥 it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…7230#section-3.3
from owncloud/core#25835
@nickvergessen @MorrisJobke you have had concerns in the original PR