204 and 304 must not have a body, see https://tools.ietf.org/html/rfc7230#section-3.3 #25835
Conversation
|
@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @MorrisJobke to be potential reviewers |
|
Well this basically means that OCS v2 is not compatible with the RFC in this case, because OCS always expects their own body. |
|
This is only for v2 - right? |
|
👍 |
| if ($this->getStatus() === Http::STATUS_NO_CONTENT | ||
| || $this->getStatus() === Http::STATUS_NOT_MODIFIED | ||
| ) { | ||
| $response = null; |
There was a problem hiding this comment.
Maybe also log that the content was truncated. Otherwise this is weird behavior to get the body just deleted. Debug should be enough.
There was a problem hiding this comment.
I don't want to add a dependency on the logger. The Response class is too important and should still function if the logging breaks so the user gets a response ... I have seen that kind of problem too often.
|
From reading the log, tests passed except OCI that timed out. |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The activity app always sets content, even for a for a 304 response, which makes firewalls cry:
Instead of fixing the app I chose to make the appframework do a sanity check in case another app misbehaves.
backport to oc9 requested.
cc @felixboehm