Avatar fixes for access-control app

[nickvergessen]

Fix nextcloud/files_accesscontrol#32

Steps

1. Create files access rule to block by "File tagged with test"
2. Upload an image
3. Assign tag test to the image
4. Go to personal settings, select avatar from folder and select the tagged image

Before

An error occurred: Internal Server Error (500)

After

The selected file cannot be read

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @rullzer and @Kondou-ger to be potential reviewers

[rullzer]

So the first part we can catch. (If preview endpoint return 403 then just display the mimetype icon).

The second one might be a bit trickier.

[rullzer]

Of course all the logic in oc-dialogs is slightly different. Basically we want to call lazyloadpreview on the previews in the dialog. But for some reason this fails hard for me.

I'm not sure howe we can go around not displaying those items. As migcally filtering them out is also kind of weird.

[nickvergessen]

Ready to review, since the open issues have been addressed by #1756

@MorrisJobke @LukasReschke @rullzer

[MorrisJobke]

Ready to review, since the open issues have been addressed by #1756

Could you post reproduction steps?

[nickvergessen]

Added steps in first post

[MorrisJobke]

@nickvergessen Unit tests are failing

[nickvergessen]

Should be fixed

[MorrisJobke]

Tested and works 👍

[LukasReschke]

LGTM

[MorrisJobke]

Ignore CI (hiccup of todays testing)-> merge