Filepicker styling #1756
Merged
Filepicker styling #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tanghus, @PVince81 and @LukasReschke to be potential reviewers. |
Member
|
Good stuff! 👍 please review too @nextcloud/designers @icewind1991 how about next thing being the #645 (sort by modified date / respect files sorting ;) ? |
Member
|
Tested and works 👍 Only one nitpick: mimetype icons are too small on IE/Edge, but this is also the case with master -> separate issue:
|
Member
|
Nice work 👍 |
Member
|
Member
|
I backported those fixes to stable10 - #1758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some minor fixes.
Brings the filepicker styling closer to the normal file list styling
Before:
After:
cc @jancborchardt