Expose password confirmation capabilities in the user backend #11786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Oct 12, 2018
lib/public/IUser.php
Outdated
| public function getBackendClassName(); | ||
|
|
||
| /** | ||
| * Get the backend for the ccurrent user object |
rullzer
added
3. to review
rullzer
force-pushed
the
feature/password_confirmation_backend
branch
from
9f6327b to
d8fb024
Compare
Member
Author
|
All done. |
On some backends (saml for example) users can't revalidate their passwords as Nextcloud has no way to do verify it. Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
If the userbackend doesn't allow validating the password for a given uid then there is no need to perform this check. Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
feature/password_confirmation_backend
branch
from
d8fb024 to
90c4b7d
Compare
MorrisJobke
approved these changes
Nov 5, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense 👍 Tested and works 🎉
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow user backends to expose if a users password can be validated. This can be useful in several places and allows us to proper do instanceof checks instead of magic string comparisons.
@blizzz as discussed.