Skip to content

Expose password confirmation capabilities in the user backend #11786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 5 commits into from
Nov 5, 2018
Merged

Expose password confirmation capabilities in the user backend #11786

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df4fa26
New user backend interface to check if a user can confirm passwords
rullzer Oct 11, 2018
1fd640b
Expose the backend of IUser
rullzer Oct 11, 2018
603b672
Update password confirmation middleware
rullzer Oct 11, 2018
60bcae5
Expose the info to the JS
rullzer Nov 2, 2018
90c4b7d
Bump autoloaders
rullzer Nov 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update password confirmation middleware 
If the userbackend doesn't allow validating the password for a given uid
then there is no need to perform this check.

Signed-off-by: Roeland Jago Douma <[email protected]>
  • Loading branch information
@rullzer
rullzer committed Nov 2, 2018
commit 603b672a113a33aef2e230f2720734078d702ff6
8 changes: 8 additions & 0 deletions lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\ISession;
use OCP\IUserSession;
use OCP\User\Backend\IPasswordConfirmationBackend;

class PasswordConfirmationMiddleware extends Middleware {
/** @var ControllerMethodReflector */
Expand Down Expand Up @@ -70,6 +71,13 @@ public function beforeController($controller, $methodName) {
$user = $this->userSession->getUser();
$backendClassName = '';
if ($user !== null) {
$backend = $user->getBackend();
if ($backend instanceof IPasswordConfirmationBackend) {
if (!$backend->canConfirmPassword($user->getUID())) {
return;
}
}

$backendClassName = $user->getBackendClassName();
}

Expand Down