Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 12, 2018

backport of #11745

Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added the 3. to review Waiting for reviews label Oct 12, 2018
@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Oct 12, 2018
@MorrisJobke
Copy link
Member

I would also love to see the acceptance tests to be run on PHP 7.3 🙈

@rullzer
Copy link
Member Author

rullzer commented Oct 12, 2018

@MorrisJobke agreed. I think they still run on 7.1 actually 🙊

@MorrisJobke
Copy link
Member

I would also love to see the acceptance tests to be run on PHP 7.3 🙈

But something for another PR.

@rullzer rullzer merged commit 91c44c8 into stable14 Oct 12, 2018
@rullzer rullzer deleted the backport/11745/stable14 branch October 12, 2018 13:32
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants