Skip to content

[14] php7.3 CI #11790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Oct 12, 2018
Merged

[14] php7.3 CI #11790

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bddf937
Add 7.3 CI to drone
rullzer Oct 10, 2018
e7d20cd
Allow php7.3
rullzer Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Allow php7.3 
Signed-off-by: Roeland Jago Douma <[email protected]>
  • Loading branch information
@rullzer
rullzer committed Oct 12, 2018
commit e7d20cdb5e8b7be335b73d3f67dffcef4bec31e2
6 changes: 3 additions & 3 deletions lib/versioncheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
exit(-1);
}

// Show warning if > PHP 7.2 is used as Nextcloud is not compatible with > PHP 7.2 for now
if (version_compare(PHP_VERSION, '7.3.0') !== -1) {
// Show warning if > PHP 7.3 is used as Nextcloud is not compatible with > PHP 7.3 for now
if (version_compare(PHP_VERSION, '7.4.0') !== -1) {
http_response_code(500);
echo 'This version of Nextcloud is not compatible with > PHP 7.2.<br/>';
echo 'This version of Nextcloud is not compatible with > PHP 7.3.<br/>';
echo 'You are currently running ' . PHP_VERSION . '.';
exit(-1);
}