Don't require Same Site Cookies on assets #11878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which can be used for public iframe embeeding See nextcloud/calendar#169 Signed-off-by: Thomas Citharel <[email protected]>
rullzer
approved these changes
Oct 17, 2018
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Makes sense.
Those endpoints are PublicPage anyway already. So people can obtain the info by a direct query.
So no leaking of info here.
rullzer
requested review from
MorrisJobke,
blizzz,
juliusknorr and
nickvergessen
blizzz
approved these changes
Oct 18, 2018
tcitworld
added a commit
that referenced
this pull request
Nov 26, 2018
This was referenced Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which can be used for public iframe embeeding
See nextcloud/calendar#169