Skip to content

Don't require Same Site Cookies on assets #11878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
Oct 18, 2018
Merged

Don't require Same Site Cookies on assets #11878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/theming/lib/Controller/ThemingController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ public function getImage(string $key, bool $useSvg = true) {
/**
* @NoCSRFRequired
* @PublicPage
* @NoSameSiteCookieRequired
*
* @return FileDisplayResponse|NotFoundResponse
* @throws NotPermittedException
Expand Down Expand Up @@ -428,6 +429,7 @@ public function getStylesheet() {
/**
* @NoCSRFRequired
* @PublicPage
* @NoSameSiteCookieRequired
*
* @return DataDownloadResponse
*/
Expand Down
1 change: 1 addition & 0 deletions core/Controller/CssController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public function __construct(string $appName,
/**
* @PublicPage
* @NoCSRFRequired
* @NoSameSiteCookieRequired
*
* @param string $fileName css filename with extension
* @param string $appName css folder name
Expand Down
1 change: 1 addition & 0 deletions core/Controller/JsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public function __construct($appName, IRequest $request, Factory $appDataFactory
/**
* @PublicPage
* @NoCSRFRequired
* @NoSameSiteCookieRequired
*
* @param string $fileName js filename with extension
* @param string $appName js folder name
Expand Down
2 changes: 2 additions & 0 deletions core/Controller/SvgController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public function __construct(string $appName,
/**
* @PublicPage
* @NoCSRFRequired
* @NoSameSiteCookieRequired
*
* Generate svg from filename with the requested color
*
Expand All @@ -73,6 +74,7 @@ public function getSvgFromCore(string $folder, string $fileName, string $color =
/**
* @PublicPage
* @NoCSRFRequired
* @NoSameSiteCookieRequired
*
* Generate svg from filename with the requested color
*
Expand Down