Skip to content

Conversation

@MasterOfDeath
Copy link
Contributor

@MasterOfDeath MasterOfDeath commented Oct 27, 2018

fixes #11393

@violoncelloCH
Copy link
Member

PR #12087 targets the same issue

@rullzer rullzer added the 3. to review Waiting for reviews label Oct 29, 2018
@juliusknorr
Copy link
Member

Thank you very much for your pull request @MasterOfDeath and welcome as a Nextcloud contributor. As @violoncelloCH mentioned there is another PR #12087, that uses existing data in the frontend to indicate the default quota. I'd vote to go this approach instead of extending the backend code with another parameter.

@juliusknorr
Copy link
Member

cc @skjnldsv for feedback

Indicate users default quota

Signed-off-by: Rinat Gumirov <[email protected]>
@MasterOfDeath MasterOfDeath force-pushed the Indicate-users-default-quota branch from f884295 to 3e6ad7a Compare October 30, 2018 19:34
@kesselb
Copy link
Contributor

kesselb commented Oct 31, 2018

Ref #12159

@juliusknorr
Copy link
Member

Let's go with #12087, since that seems to be the cleanest approach code wise. Anyway thanks for the work @MasterOfDeath, I hope to see more contributions from you soon 😉

@juliusknorr juliusknorr closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate users default quota

6 participants