Skip to content

Indicate default quota #12087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AasthaGupta wants to merge 1 commit into from
Closed

Indicate default quota #12087

AasthaGupta wants to merge 1 commit into from

Conversation

@AasthaGupta
Copy link
Member

@AasthaGupta AasthaGupta commented Oct 27, 2018

screenshot from 2018-10-28 03-08-22

Fixes #11393

@AasthaGupta AasthaGupta requested a review from rullzer October 27, 2018 21:39
@violoncelloCH violoncelloCH mentioned this pull request Oct 27, 2018
Closed
@violoncelloCH
Copy link
Member

violoncelloCH commented Oct 27, 2018

PR #12081 targets the same issue

@rullzer rullzer added the 3. to review Waiting for reviews label Oct 29, 2018
@ArtificialOwl
Copy link
Member

ArtificialOwl commented Oct 30, 2018 •
edited
Loading

Thanks for your contribution, please sign your work when committing!

https://github.com/nextcloud/appstore/blob/master/CONTRIBUTING.md#sign-your-work

@AasthaGupta
Indicate default quota
6f628de 
Fixes #11393

Signed-off-by: Aastha Gupta <[email protected]>
@AasthaGupta
Copy link
Member Author

AasthaGupta commented Oct 30, 2018

Thanks @daita .Signed.

kesselb
kesselb reviewed Oct 30, 2018
View reviewed changes
.htaccess
</IfModule>
#### DO NOT CHANGE ANYTHING ABOVE THIS LINE ####

ErrorDocument 403 /server/
Copy link
Contributor

@kesselb kesselb Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this?

@kesselb
Copy link
Contributor

kesselb commented Oct 30, 2018 •
edited
Loading

Regenerating core/vendor/core.js
The merged vendor file is not up to date
Please run: php build/mergejs.php
And commit the result

CI failure

juliusknorr
juliusknorr reviewed Oct 30, 2018
View reviewed changes
core/js/mimetypelist.js
"text/x-shellscript": "text/code",
"web": "text/code",
"application/internet-shortcut": "link"
"web": "text/code"
Copy link
Member

@juliusknorr juliusknorr Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change also doesn't belong here 😉

@juliusknorr
Copy link
Member

juliusknorr commented Oct 30, 2018

  • There seems to be a bug if the default quota is set to unlimited. In that case the UI always shows 1GB for users with default quota.

@juliusknorr juliusknorr added 2. developing Work in progress papercut Annoying recurring UX issue with possibly simple fix. feature: settings and removed 3. to review Waiting for reviews labels Oct 30, 2018
@kesselb
Copy link
Contributor

kesselb commented Oct 31, 2018

Ref #12159

@juliusknorr juliusknorr mentioned this pull request Nov 2, 2018
Closed
@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Nov 2, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Nov 6, 2018

If not fixed today, I'm afraid this will have to go to 16 :(

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 6, 2018

@skjnldsv you could also cherry pick Update the branch right here to help out and get it into shape.

This was referenced Nov 6, 2018
Merged
Merged
@ChristophWurst ChristophWurst mentioned this pull request Jan 30, 2019
Closed
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 30, 2019

-> integrated the review feedback in a cherry-picked version: #13909

@ChristophWurst ChristophWurst deleted the Aastha/11393 branch January 30, 2019 09:09
@ChristophWurst ChristophWurst removed this from the Nextcloud 16 milestone Jan 30, 2019
@ChristophWurst ChristophWurst removed the 2. developing Work in progress label Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@kesselb kesselb kesselb left review comments

@rullzer rullzer Awaiting requested review from rullzer

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

feature: settings papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@AasthaGupta @violoncelloCH @ArtificialOwl @kesselb @juliusknorr @skjnldsv @MorrisJobke @ChristophWurst @rullzer