Skip to content

Conversation

@z0iberg
Copy link

@z0iberg z0iberg commented Oct 27, 2018

Fix issue that has @Req. This commit was proposed by @Req, but he doesn't make this commit.
#12007 (comment)

@violoncelloCH
Copy link
Member

consider #12007 (comment) by @Req before merging this

@rullzer rullzer added the 3. to review Waiting for reviews label Oct 29, 2018
@juliusknorr
Copy link
Member

I would rather vote to add a more complete ES6 polyfill or fix the occurenced of startsWith. Probably the first one would be nice, since it would make developing plain js code a bit easier in the future. IE11 seems to be the only browser that would still need those polyfills.

https://github.com/paulmillr/es6-shim might be an oppinion. We currently already have a es6-promise polyfill (which is included unminified and has about 32kb) es6-shim has a minified size of 55kb. cc @nextcloud/javascript

@blizzz blizzz added this to the Nextcloud 15 milestone Nov 1, 2018
@blizzz blizzz added the bug label Nov 1, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 6, 2018
29 tasks
@juliusknorr
Copy link
Member

As discussed I've created a pr to add es6-shim in #12317 however for backporting, i would just use the startsWith polyfill from this PR to keep the stable branches clean from the dependency change. cc @nextcloud/javascript

@juliusknorr
Copy link
Member

This PR got replaced by #12317 Thanks for getting this started anyway @z0iberg

@juliusknorr juliusknorr closed this Nov 7, 2018
@MorrisJobke
Copy link
Member

@juliushaertl Didn't we want to backport this one to stable14?

@juliusknorr
Copy link
Member

@MorrisJobke Backport of this in #12339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants