Skip to content

fix - Add to favorites not working in IE11 - polyfill needed #12007 #12083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
z0iberg wants to merge 2 commits into from
Closed

fix - Add to favorites not working in IE11 - polyfill needed #12007 #12083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
003f175
fix bugs, that occurreds fatal errors
yko-keepit Oct 27, 2018
67a26df
fix - Add to favorites not working in IE11 - polyfill needed #12007
yko-keepit Oct 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/js/js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2428,3 +2428,9 @@ jQuery.fn.tipsy = function(argument) {
}
return this;
};

/**
* Add to favorites not working in IE11 - polyfill needed #12007
* @link https://github.com/nextcloud/server/issues/12007
*/
if (!String.prototype.startsWith) { String.prototype.startsWith = function(searchString, position) { position = position || 0; return this.indexOf(searchString, position) === position; }; }
4 changes: 2 additions & 2 deletions tests/lib/Traits/EncryptionTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ trait EncryptionTrait {
abstract protected function registerStorageWrapper($name, $wrapper);

// from phpunit
abstract protected function markTestSkipped($reason = '');
abstract protected function assertTrue($condition, $message = '');
abstract protected function markTestSkipped(string $message = '');
abstract protected function assertTrue($condition, string $message = '');

private $encryptionWasEnabled;

Expand Down
2 changes: 1 addition & 1 deletion tests/startsessionlistener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class StartSessionListener implements TestListener {

use TestListenerDefaultImplementation;

public function endTest(Test $test, $time) {
public function endTest(Test $test, float $time) :void {
// reopen the session - only allowed for memory session
if (\OC::$server->getSession() instanceof Memory) {
/** @var $session Memory */
Expand Down