Skip to content

fix 2fa backup codes typo #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Sep 6, 2016
Merged

fix 2fa backup codes typo #1279

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c579768
fix 2fa backup codes typo
ChristophWurst Sep 6, 2016
ea6562a
translate 2fa backup strings
ChristophWurst Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix 2fa backup codes typo
  • Loading branch information
@ChristophWurst
ChristophWurst authored Sep 6, 2016
commit c57976879c33230104e87016b7ebac11cc38ef77
4 changes: 2 additions & 2 deletions apps/twofactor_backupcodes/js/settingsview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@
},
_onPrintBackupCodes: function () {
var url = this._getDownloadDataHref();
window.open(url, 'Nextcloud backpu codes');
window.open(url, 'Nextcloud backup codes');
Copy link
Member

@nickvergessen nickvergessen Sep 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw should this be translatable?

Copy link
Member

@nickvergessen nickvergessen Sep 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all other strings in here

Copy link
Member Author

@ChristophWurst ChristophWurst Sep 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. Fixed that (found only one other string that was not yet translated)

window.print();
window.close();
}
});

OC.Settings.TwoFactorBackupCodes.View = View;

})(OC, Handlebars, $, _);
})(OC, Handlebars, $, _);