fix 2fa backup codes typo #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
| _onPrintBackupCodes: function () { | ||
| var url = this._getDownloadDataHref(); | ||
| window.open(url, 'Nextcloud backpu codes'); | ||
| window.open(url, 'Nextcloud backup codes'); |
Member
There was a problem hiding this comment.
btw should this be translatable?
Member
There was a problem hiding this comment.
Same for all other strings in here
Member
Author
There was a problem hiding this comment.
good catch. Fixed that (found only one other string that was not yet translated)
Member
Author
|
btw, will the transifex export/import automatically find this new app or do we have to add this somewhere? cc @MorrisJobke |
Member
|
👍 |
ChristophWurst
added
4. to release
Member
I will add it |
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nickvergessen @rullzer